Skip to content
This repository was archived by the owner on Dec 21, 2021. It is now read-only.

Change binary location in apt package to be consistent with all other packages#304

Merged
soenkeliebau merged 4 commits into
mainfrom
#301_binary-location
Sep 13, 2021
Merged

Change binary location in apt package to be consistent with all other packages#304
soenkeliebau merged 4 commits into
mainfrom
#301_binary-location

Conversation

@soenkeliebau
Copy link
Copy Markdown
Member

@soenkeliebau soenkeliebau commented Sep 13, 2021

Currently the agent binary is in different places for the rpm and the apt package:

RPM: /opt/stackable/stackable-agent/stackable-agent
APT: /opt/stackable-agent/stackable-agent

This commit changes to location on APT packages to /opt/stackable/stackable-agent/stackable-agent as well, so that this is consistent for all delivery mechanisms. This also matches the binary location for all Stackable operators.

Fixes #301

Description

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)

…binaries and rpm package.

Currently the agent binary is in different places for the rpm and the apt package:

RPM: /opt/stackable/stackable-agent/stackable-agent
APT: /opt/stackable-agent/stackable-agent

This commit changes to location on APT packages to /opt/stackable/stackable-agent/stackable-agent as well, so that this is consistent for all delivery mechanisms.

Fixes #301
Copy link
Copy Markdown
Member

@siegfriedweber siegfriedweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should be mentioned in the changelog.

Comment thread Cargo.toml Outdated
Comment thread packaging/debian/service
Copy link
Copy Markdown
Member

@siegfriedweber siegfriedweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link reference is missing in the changelog.

Comment thread CHANGELOG.md
Co-authored-by: Siegfried Weber <mail@siegfriedweber.net>
Copy link
Copy Markdown
Member

@siegfriedweber siegfriedweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soenkeliebau soenkeliebau merged commit 9a6b10b into main Sep 13, 2021
@soenkeliebau soenkeliebau deleted the #301_binary-location branch September 13, 2021 12:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Binary path in DEB package is incorrect

2 participants